Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #21313: Renewing performance awesomebar metrics #21315

Merged
merged 2 commits into from
Sep 27, 2021
Merged

For #21313: Renewing performance awesomebar metrics #21315

merged 2 commits into from
Sep 27, 2021

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Sep 15, 2021 •
edited
Loading

For #21313

Needs data review before landing

Renewing the following metrics:

perf.awesomebar:

  • history_suggestions
  • bookmark_suggestions
  • search_engine_suggestions
  • session_suggestions
  • synced_tabs_suggestions
  • shortcuts_suggestions
  • clipboard_suggestions

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners September 15, 2021 19:46
@eliserichards
Copy link
Author

eliserichards commented Sep 15, 2021 •
edited
Loading

Request for Data Collection Renewal

perf.awesomebar:
* history_suggestions
* bookmark_suggestions
* search_engine_suggestions
* session_suggestions
* synced_tabs_suggestions
* shortcuts_suggestions
* clipboard_suggestions

  1. Provide a link to the initial Data Collection Review Request for this collection.

  2. When will this collection now expire?

    • All probes that were set to expire in November 2021 will now expire in November 2022.

  3. Why was the initial period of collection insufficient?

    • These metrics are used to track performance regressions in the awesomebar, so we want to keep them around.

@eliserichards eliserichards added the needs:data-review PR is awaiting a data review label Sep 15, 2021
@eliserichards
Copy link
Author

Tagging you for data review @travis79 😄

@eliserichards eliserichards linked an issue Sep 15, 2021 that may be closed by this pull request
[Telemetry] Renew/delete probes for Nov/Dec #21313
Closed
@eliserichards eliserichards added this to the 94 milestone Sep 15, 2021
@travis79
Copy link
Member

Tagging you for data review @travis79 😄

Probably have time tomorrow or Friday, if later than that I'll see if someone else can get to it sooner. Thanks!

@travis79
Copy link
Member

Request for Data Collection Renewal

perf.awesomebar:

  • history_suggestions

  • bookmark_suggestions

  • search_engine_suggestions

  • session_suggestions

  • synced_tabs_suggestions

  • shortcuts_suggestions

  • clipboard_suggestions

    1. Provide a link to the initial Data Collection Review Request for this collection.

    2. When will this collection now expire?

      • All probes that were set to expire in November 2021 will now expire in November 2022.

    3. Why was the initial period of collection insufficient?

      • These metrics are used to track performance regressions in the awesomebar, so we want to keep them around.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-reveiw+

travis79
travis79 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-review+

@travis79 travis79 removed the needs:data-review PR is awaiting a data review label Sep 16, 2021
@eliserichards eliserichards added the needs:review PRs that need to be reviewed label Sep 27, 2021
grigoryk
grigoryk approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@grigoryk grigoryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @eliserichards !

app/metrics.yaml Outdated
@@ -4102,13 +4102,14 @@ perf.awesomebar:
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/10276#pullrequestreview-411101979
- https://github.com/mozilla-mobile/fenix/pull/19924#issuecomment-861423789
- https://github.com/mozilla-mobile/fenix/pull/TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#21315 (comment)

@grigoryk
Copy link
Contributor

Please also check-in the updatedmd files, I think running a build should produce the necessary diff.

For mozilla-mobile#21313: renewing performance awesomebar metrics
3f8c35e 
Add data review link to renewed metrics
@eliserichards eliserichards force-pushed the 21313-perf-nov-renewals branch from c93d922 to 3f8c35e Compare September 27, 2021 20:39
@eliserichards
Copy link
Author

The .md file is no longer being generated here, see this 👍

@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:do-not-land needs:review PRs that need to be reviewed labels Sep 27, 2021
@eliserichards
Copy link
Author

Flaky test, the same one I'm seeing in this PR

  • TitleHeaderBindingTest. WHEN grouped tabs are added to the list THEN return false

@eliserichards eliserichards reopened this Sep 27, 2021
@eliserichards
Copy link
Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2021

Command rebase: success

Branch already up to date

@eliserichards
Copy link
Author

More tests failing:

  • BrowserStateTest. GIVEN a tab group exists WHEN recentTabs is called THEN return a tab group
  • BrowserStateTest. GIVEN the selected tab is a normal tab and tab group exists WHEN asRecentTabs is called THEN return a list of these tabs

@eliserichards eliserichards removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Sep 27, 2021
@eliserichards eliserichards reopened this Sep 27, 2021
@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Sep 27, 2021
@eliserichards eliserichards merged commit ab13ae0 into mozilla-mobile:main Sep 27, 2021
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this pull request Oct 1, 2021
@pkirakosyan
For mozilla-mobile#21313: renewing performance awesomebar metrics (mo…
d27081e 
…zilla-mobile#21315)
@eliserichards eliserichards mentioned this pull request Oct 7, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@travis79 travis79 travis79 approved these changes

@grigoryk grigoryk grigoryk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
94
Development

Successfully merging this pull request may close these issues.

[Telemetry] Renew/delete probes for Nov/Dec
3 participants
@eliserichards @travis79 @grigoryk